Fix bug that overwrites ensemble ancil data in calculate_point_estimates
method
#83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #82
Updated logic in
calculate_point_estimates
to conditionally create or append to ancil dictionary.Problem & Solution Description (including issue #)
Prior to this change the last step in the
calculate_point_estimates
function would callqp_ensemble.set_ancil(...)
. That function will replace any existing ancil dictionary with the new one that is passed in.Now, we'll check to see if the ensemble's ancil data is non-None. If so, we append the new dictionary to the existing ancil dictionary. If an ancil dictionary hasn't already been created, we'll add the new dictionary to the ensemble as the ancil dict.
Code Quality
#pragma: no cover
; in the case of a bugfix, a new test that breaks as a result of the bug has been added